-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Street geo editor #540
Street geo editor #540
Conversation
👷 Deploy Preview for 3dstreet-core-builds processing.
|
Thanks for the start
|
Another question is make the coordinate field read-only or add a handler to allow user to enter coordinates and change the map? Because now an error appears when changing coordinates via input |
If add 'reference-layers' to the |
match google tiles 3d rotation fix zoom
add SF lat/long default, satellite view zoomed in by default
…al if it is available
Ok. It looks like it all working now. I just noticed that the aspect ratio of the camera in Plan View does not adapt to the screen. I need to fix this. |
It looks like the geopanel does not display the long/lat/elevation as it did before. I testing other stuff to see if it's all working
Yes, although I think this was already a solved problem in the a-frame inspector so there may be an easy fix to port over. 3DStreet/3dstreet-editor#185 |
* update submodule for dist latest to add: waymo, uoregon objects, light rail vehicle size update * add u of o objects 3DStreet/3dstreet-assets-source#84 * add waymo * fix tram path for updated size * update submodule for trash truck * trash truck
thanks, I forgot about this. Yesterday I spent half a day debugging the work of 3dtiles + Editor. Was focused on this. |
@Algorush did testing today and the only "showstopper" issue I found was elevation is a confusing thing for user to edit directly, instead it would be helpful to provide that value on behalf of the user. In this glitch project there is an example of vanilla js method using ElevationService to get elevation for a given lat / lon. I would suggest that we do the same thing -- when a user clicks on a place on the map, the elevation is updated based on that lat/lon. https://glitch.com/edit/#!/bollard-buddy-qr-maker?path=script.js%3A43%3A0
|
Thanks! I didn't know about this feature on google maps. I'll get it to set elevation. |
Yes, in other words if a user chooses a new lat / long, then overwrite any existing elevation value with the new elevation value from the ElevationService in the modal dialog. Of course, the user still may choose to cancel and their existing scene elevation is not overwritten, but I assume that if they choose a new location they will want the elevation calculated automatically, at least at first. |
create new function setMarkerPositionAndElevation
causing local runtime errors
reduce confusion for users wishing to create a new scene
* add viewer param, hide viewer sidebar * hide sky on enter ar * Squashed commit of the following: commit 403f97e Author: Kieran Farr <[email protected]> Date: Tue Jun 4 21:39:05 2024 -0700 prevent scrolling in geomodal commit d71a7b5 Author: Kieran Farr <[email protected]> Date: Tue Jun 4 21:14:07 2024 -0700 move search input below map commit f26ec38 Author: Kieran Farr <[email protected]> Date: Tue Jun 4 21:12:41 2024 -0700 update geopanel coords from entity instead of metadata commit a4afc3a Author: Kieran Farr <[email protected]> Date: Tue Jun 4 20:49:48 2024 -0700 Add spring objects (#559) * update submodule for dist latest to add: waymo, uoregon objects, light rail vehicle size update * add u of o objects 3DStreet/3dstreet-assets-source#84 * add waymo * fix tram path for updated size * update submodule for trash truck * trash truck commit ff551ce Author: Alexander Goryushkin <[email protected]> Date: Tue Jun 4 22:55:20 2024 -0400 update three-loader-3dtiles lib version commit d1cbe64 Author: Alexander Goryushkin <[email protected]> Date: Tue Jun 4 22:54:00 2024 -0400 remove old line to work 3dtiles with editor commit c7a79fe Author: Alexander Goryushkin <[email protected]> Date: Tue Jun 4 22:52:33 2024 -0400 dynamically load aframe-loader-3dtiles-component, update code for it commit c9a1a03 Author: Alexander Goryushkin <[email protected]> Date: Tue Jun 4 20:37:50 2024 -0400 new aframe-loader-3dtiles dist set Editor camera if its active on init update lat,long and/or height in runtime commit 2a04971 Author: Alexander Goryushkin <[email protected]> Date: Tue Jun 4 20:15:38 2024 -0400 don't store geo coords in metadata. Store it in street-geo commit 43d7714 Merge: abee710 d15bd99 Author: Alexander Goryushkin <[email protected]> Date: Tue Jun 4 14:12:32 2024 -0400 Merge branch 'street-geo-editor' of https://github.com/3DStreet/3dstreet into street-geo-editor commit abee710 Author: Alexander Goryushkin <[email protected]> Date: Tue Jun 4 14:12:00 2024 -0400 get GOOGLE_API_KEY from firebaseConfig.apiKey commit d15bd99 Author: Vincent Fretin <[email protected]> Date: Tue Jun 4 18:24:26 2024 +0200 remove the whole dist folder and add it to gitignore commit 695418a Merge: b148095 5b9dc54 Author: Alexander Goryushkin <[email protected]> Date: Mon Jun 3 23:58:12 2024 -0400 Merge branch 'street-geo-editor' of https://github.com/3DStreet/3dstreet into street-geo-editor commit b148095 Author: Alexander Goryushkin <[email protected]> Date: Mon Jun 3 23:57:24 2024 -0400 save/load geoData in JSON file * merge assets too * add pro badge to geo this should be visible but disabled for non-pro users * remove unneeded icons file * fix autocomplete styling * assets submodule update * qr-code-ui-wip next - upon click, then download png of qr code (or open in new tab) * wip qrhandler need qr code * Squashed commit of the following: commit c1b4c26 Author: Kieran Farr <[email protected]> Date: Thu Jun 6 22:29:31 2024 -0700 pro user required for cloud save with long/lat commit 165866a Author: Kieran Farr <[email protected]> Date: Thu Jun 6 22:12:17 2024 -0700 untitled instead of new scene reduce confusion for users wishing to create a new scene commit e27b8cd Author: Kieran Farr <[email protected]> Date: Thu Jun 6 22:11:52 2024 -0700 wHoops * do not load geo upon ar mode why not just hide geospatial layers upon ar mode instead of preventing their load? because some of them are super heavy and can crash mobile devices * update submodules and such
first version for this issue: #526
Implemented all from issue list except hide the properties panel for entities with "autocreated" class.
There is an open question about adding an
elevation
field.I also need to add a change Marker position on the map when entering location manually in the
location
field (new location or current location?).And also I forgot that I need to move geo icon somewhere or help icon. Because now they overlap